Screenshot is not attached when testing outline scenarios.#121
Conversation
ceniy
commented
Feb 24, 2021
ceniy
commented
- When outline scenarios are executed, the ScenarioTested::BEFORE and ScenarioTested::AFTER are not triggered. So I added ExampleTested::BEFORE and ExampleTested::AFTER in the event list.
- Removed the codes in onAfterOutlineTested as the count will be added inside onAfterScenarioTested
|
Looks good for me but we should wait some time. |
|
I checked the constants. Looks good but i cant test it now. Do you think this will break anything? If not i will merge it. |
|
I tested in my local with outline scenarios and normal scenarios. They work fine. The count of the passed and failed scenarios are correct. Furthermore screenshots are attached in the correct place. |
|
Then thank you for your contribution. Everything helps :) |
|
Hmm i will look into it. But i have to setup my pipeline again. If anybody is intrested in something automated go for it. |
|
So what is the state of this PR? |
|
@kalkin I think this PR will break stuff. |
|
@kalkin is this PR still important to you? I will be more active in the next time and i will check your PR as well again if it breaks stuff or not else i will merge all the things to the current master |
3 participants
